[Freeciv-Dev] Re: [RFC] x & (1u << y)
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
--- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> There are a lot of constructs like "x & (1u << y)" in the code:
> - city options, flags and roles
> - shared vision
> - embassy
> - claims
> - gotohand
> - known and sent in maphand
>
> These all are used as a bool but aren't a bool. Should they be wrapped
> with BOOL_VAL, a new test_bit or with functions specific to the
> domains above?
Definitely 2 or 3 and my preference is 3
But they should all use underlying set_bit/test_bit macro/function.
G.
__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com
|
|
