[Freeciv-Dev] Re: citytools.c:1306: package_dumb_city: Assertion `pcity != ((void *)0)' failed (PR#1260)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Feb 12, 2002 at 01:15:16AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> This happened during a server autogame.
> 
> (gdb) bt
> #0  0x400eb8d1 in __kill () from /lib/libc.so.6
> #1  0x400eb64d in raise (sig=6) at ../sysdeps/posix/raise.c:27
> #2  0x400eccb8 in abort () at ../sysdeps/generic/abort.c:88
> #3  0x400e4d71 in __assert_fail (assertion=0x80c5aca "pcity != ((void 
> *)0)",
>      file=0x80c598c "citytools.c", line=1306,
>      function=0x80c5ab8 "package_dumb_city") at assert.c:74
> #4  0x08061330 in package_dumb_city (pplayer=0x8145cc8, x=17, y=35,
>      packet=0xbffff080) at citytools.c:1306
> #5  0x08061846 in send_city_info_at_tile (pviewer=0x8145cc8, 
> dest=0x814826c,
>      pcity=0x0, x=17, y=35) at citytools.c:1504
> #6  0x0807284a in really_give_tile_info_from_player_to_player (
>      pfrom=0x812d548, pdest=0x8145cc8, x=17, y=35) at maphand.c:1027
> #7  0x0807290a in give_tile_info_from_player_to_player (pfrom=0x812d548,
>      pdest=0x8145cc8, x=17, y=35) at maphand.c:1050
> #8  0x08070f7f in give_map_from_player_to_player (pfrom=0x812d548,
>      pdest=0x8145cc8) at maphand.c:236
> #9  0x08075f97 in split_player (pplayer=0x812d548) at plrhand.c:1627
> #10 0x08076091 in civil_war (pplayer=0x812d548) at plrhand.c:1724
> #11 0x08061282 in handle_unit_enter_city (punit=0x82b44f8, pcity=0x8208c70)
>      at citytools.c:1276
> #12 0x0805c843 in handle_unit_move_consequences (punit=0x82b44f8, src_x=1,
>      src_y=38, dest_x=0, dest_y=38) at unittools.c:2792
> #13 0x0805cef4 in move_unit (punit=0x82b44f8, dest_x=0, dest_y=38,
>      transport_units=1, take_from_land=1, move_cost=3) at unittools.c:3005
> #14 0x08055b8f in handle_unit_move_request (punit=0x82b44f8, dest_x=0,
>      dest_y=38, igzoc=0, move_diplomat_city=0) at unithand.c:1075
> #15 0x080b54cb in ai_military_attack (pplayer=0x8130638, punit=0x82b44f8)
>      at aiunit.c:1552
> #16 0x080b5c32 in ai_manage_military (pplayer=0x8130638, punit=0x82b44f8)
>      at aiunit.c:1786
> #17 0x080b60d8 in ai_manage_units (pplayer=0x8130638) at aiunit.c:1943
> #18 0x0804cc6b in ai_start_turn () at srv_main.c:366
> #19 0x0804ed96 in main_loop () at srv_main.c:1680
> #20 0x0804f414 in srv_main () at srv_main.c:1971
> #21 0x0804a079 in main (argc=5, argv=0xbffff844) at civserver.c:147
> #22 0x400d9306 in __libc_start_main (main=0x8049b60 <main>, argc=5,
>      ubp_av=0xbffff844, init=0x804947c <_init>, fini=0x80b7140 <_fini>,
>      rtld_fini=0x4000d2dc <_dl_fini>, stack_end=0xbffff83c)
>      at ../sysdeps/generic/libc-start.c:129

There is a player-city but no real city at this position. Maybe the
player-cities aren't correctly removed if a real city is destroyed?

> It does not appear to be reproducable from the savegame.

Quite possible since the player-city is dynamic (read: not saved in
the savegame AFAIK).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "> WHY?! Isn't it better to put $(shell cat cscope.files) on the list of
  I only have a yellow belt in makefile kungfu.  These fancy gnu make things
  are relatively new to some of us..."
    -- Mark Frazer to Vassilii Khachaturov in linux-kernel