[Freeciv-Dev] Re: [FreeCiv-Cvs] kauf: general cleanup of find_a_direction() as well ...

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Jan 31, 2002 at 02:51:02PM -0800, freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> This is an automated notification of a change to freeciv cvs, 
> on Thu Jan 31 14:48:27 PST 2002 = Thu Jan 31 22:48:28 2002 (GMT)
> by Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>
> 
> ---- Files affected:
> 
> freeciv/server gotohand.c maphand.c maphand.h
> 
> ---- Log message:
> 
> general cleanup of find_a_direction() as well as make triremes 
> safer by having them attempt to find coast if there no alternative.
> 
> add a function is_coast_seen() to take advantage of the knowledge
> that a coastal tile shows a land strip near the edge even if it's
> otherwise unknown. [Note: this is a strong indication that the
> client knows more than it should]
> 
> Patch by Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>

Attached is an cleanup for the cleanup patch. Gregory didn't made the
patch and I didn't have time till now. It contains the usual stuff:
 - remove variables which aren't needed
 - move variables into the deepest possible scope
 - add {}
 - feed through indent
 - add constants and macros to make the code more clear

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "A common mistake that people make, when trying to design 
  something completely foolproof is to underestimate the 
  ingenuity of complete fools."
    -- Douglas Adams in Mostly Harmless

find_a_direction_cleanup1.diff
Description: Text document