[Freeciv-Dev] civclient loops infinitely with corrupted network data (PR#1247)

[Christian Knoke <ChrisK@xxxxxxxx>]

Recent CVS + CMA 3.4

Civclient loops, spoiling

1: Received unknown packet (type 0) from server!
1: received short packet (type 0, len 0) from server

again and again, seemingly because it receives data
it doesn't expect, at a time when the other side
already has aborted. I report it, though it won't
happen with an intact civserver:

(gdb) bt
#0  0x403d5da4 in write () from /lib/libc.so.6
#1  0x4042a944 in __DTOR_END__ () from /lib/libc.so.6
#2  0x40379a59 in new_do_write () from /lib/libc.so.6
#3  0x4037a56c in _IO_new_file_xsputn () from /lib/libc.so.6
#4  0x4035e8cf in buffered_vfprintf () from /lib/libc.so.6
#5  0x40359eff in vfprintf () from /lib/libc.so.6
#6  0x40362e97 in fprintf () from /lib/libc.so.6
#7  0x080b0663 in log_write (fs=0x40427de0, level=1, 
    message=0x8136540 "received short packet (type 0, len 0) from server")
at log.c:213
#8  0x080b08f9 in vreal_freelog (level=1, 
    message=0x80d8380 "received short packet (type %d, len %d)%s",
ap=0xbffff1ec)
    at log.c:283
#9  0x080b095a in real_freelog (level=1, 
    message=0x80d8380 "received short packet (type %d, len %d)%s") at
log.c:295
#10 0x080b4078 in pack_iter_end (piter=0xbffff30c, pc=0x8158ba0) at
packets.c:606
#11 0x080b8183 in receive_packet_req_join_game (pc=0x8158ba0) at
packets.c:2736
#12 0x080b3b69 in get_packet_from_connection (pc=0x8158ba0,
ptype=0xbffff384, 
    presult=0xbffff388) at packets.c:341
#13 0x08063205 in input_from_server (fid=6) at clinet.c:330
#14 0x0808e872 in get_net_input (data=0x0, fid=6, condition=GDK_INPUT_READ)
    at gui_main.c:844
#15 0x40193934 in gdk_io_invoke () from /usr/lib/libgdk-1.2.so.0
#16 0x401c53b0 in g_io_unix_dispatch () from /usr/lib/libglib-1.2.so.0
#17 0x401c6c46 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
#18 0x401c7273 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
#19 0x401c743c in g_main_run () from /usr/lib/libglib-1.2.so.0
#20 0x400df76c in gtk_main () from /usr/lib/libgtk-1.2.so.0
#21 0x0808e855 in ui_main (argc=3, argv=0xbffff624) at gui_main.c:836
#22 0x08060511 in main (argc=3, argv=0xbffff624) at civclient.c:191
#23 0x403277ee in __libc_start_main () from /lib/libc.so.6

Christian

-- 
http://www.enter.de/~c.knoke/  * * * * * * * * * * * * * * *
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.