[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Dec 22, 2001 at 11:28:45AM +0100, Petr Baudis wrote:
> Dear diary, on Sat, Dec 22, 2001 at 09:45:23AM CET, I got a letter, where
> Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> told me, that...
> > Another option to "a maintainer has to work on almost all parts of the code"
> > is to say that a maintainer is a specialist (AI, map, GUI, ...). We would 
> > get
> > maintainers if we follow this way but I think this way is wrong. Such a
> > maintainer won't have to whole picture and will produce architecturally bad
> > code.
> And why he need to have whole picture in order to produce architecturally good
> code, if he will just accept i.e. some changes in AI?

Ack. Knowledge outside isn't required in all cases. However the
distinction is hard to make. 

> ;) 

> Maybe higher level of encapsulation and defined interface between
> parts of freeciv would help this a lot

Ack. Removing the AI from the server from example. Or weaker: make the
AI and the core server more seperate (core server doesn't call ai_*
methods and AI doesn't change values directly).

> - if he will abide the defined interface, he doesn't need to worry
> so much.  Hey, and it would help creating civbot too! :)
> 
> > I'm sorry but I have to leave now. Goodbye till the first week of the new
> > year.
> Merry christmas and happy new year :).

Thanks. Mhh it is a bit too late to wish you the same ;)

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Microsoft does have a year 2000 problem. I'm part of it. I'm running Linux.