[Freeciv-Dev] Re: PATCHES: AI cleanups (PR#1176)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> wrote:
> > Ok, I am resending the patch with 3 instead of SINGLE_MOVE. I don't
> > think it
> > really matters that much, I'll be getting rid of it anyway with my next
> > igter
> > patch. The comments I just added is only for the moment. That comment
> 
> Fine by me if you promise to fix it within next few patches.
> 
> > I wes hoping for some comments on the correct warmap behaviour. You
> > seem to have
> > decided that the current method of multiplying the move rate of igter
> > units by 3
> > is better than 1/3 move costs per tile. I'd just like to know your
> > reasons for that decision.
> 
> I am not 100% decided but I think it should stay this way, at least until
> there is a local warmap available.  The reason is that "city" warmap is
> often used to estimate move_time for various units, in particular igter,
> so to make this approximation not so bad you need to pretend that igter
> moves 3 times further.
> 
> On your patch:
> 1. It doesn't apply cleanly (have no idea why, says
> freeciv/ 144> patch -p5 --dry-run < ~/unit_move_turns.diff
> patching file `ai/aiunit.c'
> patch: **** malformed patch at line 100: +  }
> 

OK, what is the date/time of your local cvs version?

> 2. The formatting as I see it from the diff file is horrible!!!
> Don't count on Raimar to do it for you!
> 

All right, how do you want me to reformat it?

> 3. Can you attach diff files as Plain Text.  I managed to do it on my
> computer by going to 
> Edit->Preferences->Navigator->Applications->Plain Text->Edit 
> and adding "diff" to suffixes, although there must be a better way to do
> it...
> 

You're using netscape right? I've got moz on my pc, and added diff as a new
text type. Here's hoping it works.



__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com