[Freeciv-Dev] Re: [PATCH] bug in vnotify_conn_ex()

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 11:01 AM 02/01/02 +0100, Per I. Mathisen wrote:
>On Wed, 2 Jan 2002, Jason Short wrote:
>
>If this is an indication of a bug elsewhere in the code, should this
>result in an assert() failure, or at least be logged as a warning?

This is post-1984. 

In the dawn-era passed coordinates were allowed to be anything, and 
void-tile was the patch that covered up the mess that killed Freeciv 
for a number of years and left scars on all programmers' psyches.

Pre-1984, coordinates were required to be real, and were normalized
at the point of access to things that had more strigent requirements.
Note, real coordinates can always be normalized.

Post-1984, coordinates must be normalized and all non-normalized 
coordinates are now by fiat evil and require immediate termination of 
the game (by assertion) to prevent further contamination.

The pendulum has swung a bit too far ...

So no, there is probably no bug elsewhere, just some lonely code that
has not yet been purged, or is rightly resisting the process, plus of
course the code that is about to be purged because there is a new kid
on the block that wants to take over the current system :-).

>Yours,
>Per
>
>Action expresses priorities.
> -- Mohandas Gandhi

Cheers,
RossW
=====