[Freeciv-Dev] Re: PATCH unit_name interface

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Dec 16, 2001 at 12:22:59AM +0100, Gregor Zeitlinger wrote:
> Now that I know you have to produce some patches before you're taken
> seriously, here's my first :)
> 

> I've changed the interface to unit_name from unit_name(Unit_Type_id)
> to unit_name(struct unit *) and to unit_name_by_type(Unit_Type_id)
> where appropriate.

I have planned such a patch for a long time. Only problem: can you
rename unit_name_by_type to unit_type_name?

> This is actually quite boring, but it's a pre-patch for the next one
> which will introduce the ability to give individual names to
> units. I hope this will make it easier.

> It's against CVS 2001-12-10 23:30. patch -p1 <patch to apply 

> (that's the common way, I read in the manual)

-p0 is also common since it can be generated with "cvs diff" and
doesn't need a second tree.

> Should the patch that builds on this one include this one or only be a
> diff against the current one?
> And should I port my patch to the current CVS or is there no point since
> it will take forever, if it will be included?

Wait this patch is included and than submit the other one. You may
publish the other before to let people test it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 A life? Cool! Where can I download one?