[Freeciv-Dev] Re: Is the city names patch good?

[Reinier Post <rp@xxxxxxxxxx>]

On Tue, Dec 11, 2001 at 04:52:34PM +0100, Raimar Falke wrote:
> On Tue, Dec 11, 2001 at 10:52:17AM +0100, Reinier Post wrote:
> > On Mon, Dec 10, 2001 at 11:49:50PM +0100, Takacs Gabor wrote:
> > > Hello!
> > > 
> > > I write about a patch added to Freeciv on Dec 6.
> > > 
> > > The description of the patch (from changes.txt):
> > > 
> > > > Add the ability to structure the city names of nations based
> > > > on the (surrounding) terrain. For this city_name_suggestion now
> > > > take the position of the city.
> > > 
> > > I think this patch has more disadvantages than advantages:
> > 
> > I agree.  I didn't notice it getting in.  
> 
> There were 24 messages on this topic. It started 1 month ago. There
> was no email from you or Takacs.

That's good; if a patch works and doesn't meet opposition, it ought to go in.
 
> > Isn't the new naming method optional?
> 
> No it isn't. It looked like nobody had any problems with it.
> 
> > I still prefer Falk Hueffner's naming algorithm btw.
> > 
> >   
> > http://www.complete.org/mailinglists/archives/freeciv-dev-200002/msg00374.html
> 
> Than make a bug report. And please document the code (I can't say what
> it does on a quick scan).

Falk's code generates names by recombining existing ones, so it isn't really
an alternative.

BTW my vote for the unique city names patch going in.

>       Raimar

-- 
Reinier