[Freeciv-Dev] Re: [PATCH] New City dialog happiness generalisation (PR#1116)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

Ben Webb wrote:


> 	Patch made from CVS as of Mon Dec 10th. Requires effect-init.patch 
> (PR#1104), effect-implement.patch (PR#1114) and effect-iterator.patch 
> (PR#1115) to first be applied (in order).
I'm not sure which patch the following applies to, as I was using all 
four of them when it happened.
civclient: astring.c:126: ath_minnum: Assertion `ath->size>0' failed.

(gdb) bt
#0  0x403268d1 in __kill () from /lib/libc.so.6
#1  0x4032664d in raise (sig=6) at ../sysdeps/posix/raise.c:27
#2  0x40327cb8 in abort () at ../sysdeps/generic/abort.c:88
#3  0x4031fd71 in __assert_fail (assertion=0x80c6916 "ath->size>0",
    file=0x80c68ad "astring.c", line=126, function=0x80c68fb "ath_minnum")
    at assert.c:74
#4  0x0809f749 in ath_minnum (ath=0x827d1d4, n=1) at astring.c:126
#5  0x080a7bb4 in add_effect_to_list (listpt=0x827d1d4) at improvement.c:672
#6  0x080a2e0b in city_add_improvement (pcity=0x827d010, impr=7) at 
city.c:2170
#7  0x08069879 in handle_short_city (packet=0x8243098) at packhand.c:570
#8  0x0805f56d in handle_packet_input (packet=0x8243098 "\206\001", type=82)
    at civclient.c:262
#9  0x080620d3 in input_from_server (fid=6) at clinet.c:330
#10 0x4018be7d in gdk_io_invoke (source=0x8202378, condition=G_IO_IN,
    data=0x82023d8) at gdkevents.c:882
#11 0x401baa7a in g_io_unix_dispatch (source_data=0x8202390,
    current_time=0xbffff810, user_data=0x82023d8) at giounix.c:137
#12 0x401bc055 in g_main_dispatch (dispatch_time=0xbffff810) at gmain.c:656
#13 0x401bc659 in g_main_iterate (block=1, dispatch=1) at gmain.c:877
#14 0x401bc7e8 in g_main_run (loop=0x82030f8) at gmain.c:935
#15 0x400d927b in gtk_main () at gtkmain.c:524
#16 0x080881f6 in ui_main (argc=3, argv=0xbffff954) at gui_main.c:836
#17 0x0805f458 in main (argc=3, argv=0xbffff954) at civclient.c:189
#18 0x40314306 in __libc_start_main (main=0x805f000 <main>, argc=3,
    ubp_av=0xbffff954, init=0x805c938 <_init>, fini=0x80bbf20 <_fini>,
    rtld_fini=0x4000d2cc <_dl_fini>, stack_end=0xbffff94c)

jason