[Freeciv-Dev] Re: (PR#1098)

[Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxx>]

On Fri, 7 Dec 2001, Mike Kaufman wrote:

> On Thu, Dec 06, 2001 at 09:02:31PM -0800, Vasco Alexandre Da Silva Costa 
> wrote:
> > Seems good. However tile_is_known() returns an enum. The name sounds like
> > a predicate name.
> > So wouldn't returning (map_get_tile(x,y)->known>=TILE_KNOWN_FOGGED) make
> > more sense? 
> 
> no. this function needs to return the value of map_get_tile(x,y)->known
> See tilespec.c for example. if this is confusing I'll resubmit the patch
> changing all the instances of tile_is_known() to tile_known() or a more
> suitable name if you can come up with one.

If that's the case i guess we can commit the patch as is (since you said
it was important) and change the function name in a later patch.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa