[Freeciv-Dev] Re: (PR#1098)
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Thu, Dec 06, 2001 at 09:02:31PM -0800, Vasco Alexandre Da Silva Costa wrote:
> Seems good. However tile_is_known() returns an enum. The name sounds like
> a predicate name.
> So wouldn't returning (map_get_tile(x,y)->known>=TILE_KNOWN_FOGGED) make
> more sense?
no. this function needs to return the value of map_get_tile(x,y)->known
See tilespec.c for example. if this is confusing I'll resubmit the patch
changing all the instances of tile_is_known() to tile_known() or a more
suitable name if you can come up with one.
-mike
>
> ---
> Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa
>
|
|
