[Freeciv-Dev] Re: [PATCH] tile_is_known patch (again) (PR#1098)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

Mike Kaufman wrote:

> so here's the fourth go around for this baby. Maybe sending it to bugs
> will get it in this time.
Seems like a wise move.


> I won't rehash the details. Look in the archives. Only to say that
> civworld would really like this patch to go in. Maybe over break, I'll
> get civworld to compile on cvs and fix some more bugs.
I like this patch - it moves tile_is_known, which is only used 
client-side, to the client.  Technically, it looks fine to me.
The only other thing I might want out of it is a renaming of 
tile_is_known, so that it's not so easily confused with map_get_known. 
But with ~50 places to rename the function, this is probably too intrusive.
I recommend inclusion after maintainer review.  This patch has been 
around a while, and is a beneficial change.
jason