[Freeciv-Dev] Re: Cleaning up gotohand.c (PR#1068)

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 10:29 PM 01/12/04 +0100, Petr Baudis wrote:
>Dear diary, on Tue, Dec 04, 2001 at 10:02:13PM CET, I got a letter,
>where vze2zq63@xxxxxxxxxxx told me, that...
>> A first step might be to have the warmap used be passed into 
>> [really]_generate_warmap.  Then places like air_can_move_between can 
>> safely use their local copy while other places continue to use the 
>> global variant.
>Strong agree! In fact when I came to see what that warmap code does, I was
>been shocked by use of one common warmap for everything. That's really
>ugly hack, IMHO, and needs fix :-). I can clean that in AI, if there will
>be interest in doing this.

There is code lying around that did this the right way, with a fallback
to the static global if a local parameter was not passed in.

Except for tracking down things in this case, there shouldn't be too much 
of a problem.

>-- 
>                               Petr "Pasky" Baudis
>
>UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv hacking
>.
>  "A common mistake that people make, when trying to design
>   something completely foolproof is to underestimate the
>   ingenuity of complete fools."
>     -- Douglas Adams in Mostly Harmless
>.
>Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/

Cheers,
RossW
=====