[Freeciv-Dev] Re: [FreeCiv-Cvs] vasc: Remove duplicated code from citydlg.c. Similar...

[Jason Short <vze2zq63@xxxxxxxxxxx>]

Raimar Falke wrote:

> On Tue, Dec 04, 2001 at 08:21:01PM -0800, freeciv@xxxxxxxxxxxxxxxxxxx wrote:
>
> > This is an automated notification of a change to freeciv cvs, 
> > on Tue Dec  4 20:13:04 PST 2001 = Wed Dec  5 04:13:04 2001 (GMT)
> > by Vasco Alexandre da Silva Costa <vasc@xxxxxxxxxxxxxx>
> >
> > ---- Files affected:
> >
> > freeciv/client Makefile.am Makefile.in
> > freeciv configure
> > freeciv/client/gui-gtk Makefile.in citydlg.c
> > freeciv/client/gui-mui mapclass.c
> > freeciv/client/include citydlg_g.h
> > freeciv/client/gui-win32 citydlg.c
> >
> > ---- Log message:
> >
> > Remove duplicated code from citydlg.c. Similar to the previous changes
> > to mapview.c.
> >
> > Patch from Jason Dorje Short <vze2zq63@xxxxxxxxxxx>.
> gcc -DHAVE_CONFIG_H -I. -I. -I.. -I./include -I../common -I../intl  -Wall 
> -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations 
> -Werror  -g -O2 -Wall -c citydlg_common.c
> cc1: warnings being treated as errors
> citydlg_common.c:26: warning: no previous prototype for `city_pos_to_canvas_pos'
> citydlg_common.c:48: warning: no previous prototype for `canvas_pos_to_city_pos'
My mistake.  Obviously the #include has been left out.

Here's a fix.

jason

? diff
? old
? topology
Index: client/citydlg_common.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/citydlg_common.c,v
retrieving revision 1.1
diff -u -r1.1 citydlg_common.c
--- client/citydlg_common.c     2001/12/05 04:15:50     1.1
+++ client/citydlg_common.c     2001/12/05 16:39:57
@@ -16,6 +16,7 @@
 
 #include "log.h"
 
+#include "citydlg_common.h"
 #include "tilespec.h" /* for is_isometric */
 
 /**************************************************************************