Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: buglet in normalization in init_new_game() (PR#1063)

[Freeciv-Dev] Re: buglet in normalization in init_new_game() (PR#1063)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: buglet in normalization in init_new_game() (PR#1063)
From: "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>
Date: Mon, 19 Nov 2001 22:46:34 -0500

Note, that since game coordinates are not trigonometric a circle
is a rather odd beast in Freeciv. I'm not sure where you would
really want to use it.

If you want all positions of constant distance from a centre in 
Freeciv, this is actually a square border :-).


At 12:52 PM 01/11/14 -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
>Raimar Falke wrote:
>> IMHO it looks like a job for a new circle_iterate.
>The attached patch is an adequate implementation of circle_iterate
>(actually, I'm not happy with the use of sqrt() but I'm not sure how to
>do without it), but doesn't quite work for this case because the current
>code there adds 1 to the radius before comparing it to the maximum
>radius.  So if you play with this patch the initial visible area will be
>larger than it's supposed to be.
>IMO it is the current implementation that is broken, but perhaps there's
>some reason for that.  My solution would be to adjust
>game.rgame.init_vis_radius_sq accordingly.

[Prev in Thread] Current Thread [Next in Thread]