[Freeciv-Dev] Re: buglet in normalization in init_new_game() (PR#1063)

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

Note, that since game coordinates are not trigonometric a circle
is a rather odd beast in Freeciv. I'm not sure where you would
really want to use it.

If you want all positions of constant distance from a centre in 
Freeciv, this is actually a square border :-).

Cheers,
RossW
=====

At 12:52 PM 01/11/14 -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
>Raimar Falke wrote:
>
>> IMHO it looks like a job for a new circle_iterate.
>
>The attached patch is an adequate implementation of circle_iterate
>(actually, I'm not happy with the use of sqrt() but I'm not sure how to
>do without it), but doesn't quite work for this case because the current
>code there adds 1 to the radius before comparing it to the maximum
>radius.  So if you play with this patch the initial visible area will be
>larger than it's supposed to be.
>
>IMO it is the current implementation that is broken, but perhaps there's
>some reason for that.  My solution would be to adjust
>game.rgame.init_vis_radius_sq accordingly.
>
>jason