Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: [RFC PATCH] Borders
Home

[Freeciv-Dev] Re: [RFC PATCH] Borders

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev <freeciv-dev@xxxxxxxxxxx>, freecivac-devel@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [RFC PATCH] Borders
From: Jason Dorje Short <vze2zq63@xxxxxxxxxxx>
Date: Thu, 08 Nov 2001 17:03:56 -0500
Reply-to: jdorje@xxxxxxxxxxxx

Stewart Adcock wrote:
> 
> Hi,
> 
> It has been a long time coming, but here is the next iteration of the
> borders patch against the current freeciv CVS (08 Nov).  A readme file
> is included in the patch which gives some details.
> 
> Comments?

IMO it would be good to find a more gui-independent structure.  Too
often we focus entirely on GTK, and forget that it'll take just as much
work to provide features to each of the other GUI's.  Making common code
(in client/mapview_common.[ch]) might help here.

In this screenshot:  ftp://ftp.freeciv.org/freeciv/incoming/borders.jpg,
why does Thon Buri not control the water space adjacent to it?

Aside from that, I haven't taken a deep enough look to give more
constructive advice.

jason


[Prev in Thread] Current Thread [Next in Thread]