[Freeciv-Dev] Re: [RFC PATCH] Borders

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

Stewart Adcock wrote:
> 
> Hi,
> 
> It has been a long time coming, but here is the next iteration of the
> borders patch against the current freeciv CVS (08 Nov).  A readme file
> is included in the patch which gives some details.
> 
> Comments?

IMO it would be good to find a more gui-independent structure.  Too
often we focus entirely on GTK, and forget that it'll take just as much
work to provide features to each of the other GUI's.  Making common code
(in client/mapview_common.[ch]) might help here.

In this screenshot:  ftp://ftp.freeciv.org/freeciv/incoming/borders.jpg,
why does Thon Buri not control the water space adjacent to it?

Aside from that, I haven't taken a deep enough look to give more
constructive advice.

jason