[Freeciv-Dev] Re: semi-quick tile_is_known patch [new patch]

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Oct 27, 2001 at 05:09:51PM -0500, Mike Kaufman wrote:
> > Yes.  Using map_get_tile is better.  But please change this code:
> > to
> > 
> > {
> >   return map_get_tile(x, y)->known;
> > }
> 
> ok, I agree. Here's a new patch.
> 
> > This will make things simpler for the check_map_pos changes.  Speaking
> > of which, since civworld uses this same code you should verify that
> > civworld works with the check_map_pos patch (i.e. doesn't pass around
> > non-normal coordinates anywhere).
> 
> it uses a completely stock map.c and maphand.c and a _mostly_ stock
> mapview.c, so I don't foresee real problems.
> 
> > > > > This patch is needed to remove ~60k from the civworld patch.
> > > >
> > > > It seems like a better solution would be to put civworld into freeciv's
> > > > CVS, so that source sharing would be much easier.  But I'm sure this has
> > > > been discussed before...
> > > 
> > > this won't change anything, as civworld still uses both server and
> > > client specific contructs. see above.
> > 
> > Yes, I see.  I also see you're in favor of it :-)
> > 
> > > > Finally, I'd rather see the check_map_pos patch go in before this one.
> > > > It makes this fix simpler...
> 
> But, this now becomes an easy thing for Raimar to apply. Raimar: please apply
> it.

Objections? I will otherwise apply it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Python 2.0 beta 1 is now available [...]. There is a long list of new 
  features since Python 1.6, released earlier today. We don't plan on 
  any new releases in the next 24 hours."
    -- Jeremy Hylton at Slashdot