[Freeciv-Dev] Re: semi-quick tile_is_known patch [new patch]

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

Mike Kaufman wrote:
> 
> > Yes.  Using map_get_tile is better.  But please change this code:
> > to
> >
> > {
> >   return map_get_tile(x, y)->known;
> > }
> 
> ok, I agree. Here's a new patch.

We don't yet have check_map_pos in place to catch the non-normal
coordinate error, but if that does happen map_get_tile should return
void_tile and (I think) everything should work out.  So this should be
good.

> > > > Finally, I'd rather see the check_map_pos patch go in before this one.
> > > > It makes this fix simpler...
> 
> But, this now becomes an easy thing for Raimar to apply. Raimar: please apply
> it.

With this change it no longer interferes with check_map_pos, so that's
no longer a concern.

The only other recommendation I'd make is that you put a bit more
explanation in the function comment for tile_is_known.  This, too, is a
small issue.  Aside from that, it all looks good (though I have not
verified that it's complete).

jason