[Freeciv-Dev] civserver crash (PR#1005)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

I had patched civclient slightly, but nothing outside of the client/
directory was changed.  civserver crashed upon game start.  Could be
that the client sent some bad information to the server, but this
shouldn't cause a server crash.  It appears to be reproducable, with or
without the modifications to the client.



[jshort@jason freeciv]$ ./civ -t engels & ./ser -p 5556
[2] 15148
This is the server for Freeciv version 1.12.1-devel
You can learn a lot about Freeciv at http://www.freeciv.org/
2: Now accepting new client connections.

For introductory help, type 'help'.
> 
2: Connection request from jshort from localhost.localdomain
2: jshort has client version 1.12.1-devel
2: jshort has joined as player jshort.
> set aifill 2
Option: aifill has been set to 2.
> hard
Setting game.skill_level to 7.
> aitoggle jshort
jshort is now under AI control.
jshort is now hard.
> start
Starting game.
2: Loading rulesets
2: AI is controlling the Irish ruled by jshort.
2: Tancredo Neves has been added as an AI-controlled player.
2: AI is controlling the Brazilians ruled by Tancredo Neves.
Tancredo Neves is now hard.
[1]   Done                    xemacs topology/therest.diff
Segmentation fault (core dumped)
[jshort@jason freeciv]$ 2: lost connection to server



[jshort@jason freeciv]$ gdb server/civserver core
GNU gdb 5.0rh-5 Red Hat Linux 7.1
Copyright 2001 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you
are
welcome to change it and/or distribute copies of it under certain
conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for
details.
This GDB was configured as "i386-redhat-linux"...
Core was generated by `./server/civserver -p 5556'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /lib/i686/libm.so.6...done.
Loaded symbols for /lib/i686/libm.so.6
Reading symbols from /usr/lib/libz.so.1...done.
Loaded symbols for /usr/lib/libz.so.1
Reading symbols from /lib/i686/libc.so.6...done.
Loaded symbols for /lib/i686/libc.so.6
Reading symbols from /lib/ld-linux.so.2...done.
Loaded symbols for /lib/ld-linux.so.2
Reading symbols from /lib/libnss_files.so.2...done.
Loaded symbols for /lib/libnss_files.so.2
#0  0x08070837 in map_get_known_and_seen (x=12, y=15, pplayer=0x812845c)
at maphand.c:780
780       return ((map.tiles + offset)->known) & (1u << playerid) &&
(gdb) bt
#0  0x08070837 in map_get_known_and_seen (x=12, y=15, pplayer=0x812845c)
at maphand.c:780
#1  0x080704ed in really_show_area (pplayer=0x812845c, x=12, y=15) at
maphand.c:700
#2  0x080706f3 in show_area (pplayer=0x812845c, x=13, y=16, len=1) at
maphand.c:745
#3  0x080670b1 in init_new_game () at gamehand.c:136
#4  0x0804ef52 in srv_main () at srv_main.c:1963
#5  0x08049b79 in main (argc=3, argv=0xbffff954) at civserver.c:147
#6  0x40076177 in __libc_start_main (main=0x8049660 <main>, argc=3,
ubp_av=0xbffff954, init=0x8049060 <_init>, fini=0x80b33b0 <_fini>,
rtld_fini=0x4000e184 <_dl_fini>, stack_end=0xbffff94c)
    at ../sysdeps/generic/libc-start.c:129
(gdb) quit



[jshort@jason freeciv]$ cvs up    
M client/control.c
M client/gui-gtk/dialogs.c
M client/gui-gtk/mapview.c
M client/gui-mui/graphics.c
M client/gui-mui/mapclass.c
M client/gui-mui/mapview.c
M client/gui-win32/mapview.c
M client/gui-xaw/dialogs.c
M client/gui-xaw/mapview.c


jason