[Freeciv-Dev] Re: Cleaning up server/savegame.c (PR#1000)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 09, 2001 at 03:10:26PM -0400, Jason Dorje Short wrote:
> rf13@xxxxxxxxxxxxxxxxxxxxxx wrote:
> > 
> > On Mon, Oct 08, 2001 at 05:01:17PM -0400, Jason Dorje Short wrote:
> > > Raimar Falke wrote:
> > >
> > > > Objections?
> > >
> > > Try this one instead.
> > >
> > > It now replaces all map iterations during saving (loading is
> > > independent; the patches can be applied simultaneously but there's no
> > > reason to keep them together).
> > 
> > I have made more changes that I wanted to do. So here is an updated
> > patch.
> 
> As far as I can see you've only changed the names?  I suppose the macros
> should be all-caps, but to me it looks ugly.

The arguments have changed. Formatting and docu changes.

> You've also removed the free(pbuf) call in the macro, so there's a
> memory leak now AFAICT.

I have expected such a stupid error.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The two rules for success in life are:
  1) Never tell them everything you know."