Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: Cleaning up server/savegame.c (PR#1000)
Home

[Freeciv-Dev] Re: Cleaning up server/savegame.c (PR#1000)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Cleaning up server/savegame.c (PR#1000)
From: Jason Dorje Short <vze2zq63@xxxxxxxxxxx>
Date: Tue, 09 Oct 2001 15:10:26 -0400
Reply-to: jdorje@xxxxxxxxxxxx

rf13@xxxxxxxxxxxxxxxxxxxxxx wrote:
> 
> On Mon, Oct 08, 2001 at 05:01:17PM -0400, Jason Dorje Short wrote:
> > Raimar Falke wrote:
> >
> > > Objections?
> >
> > Try this one instead.
> >
> > It now replaces all map iterations during saving (loading is
> > independent; the patches can be applied simultaneously but there's no
> > reason to keep them together).
> 
> I have made more changes that I wanted to do. So here is an updated
> patch.

As far as I can see you've only changed the names?  I suppose the macros
should be all-caps, but to me it looks ugly.

You've also removed the free(pbuf) call in the macro, so there's a
memory leak now AFAICT.

jason


[Prev in Thread] Current Thread [Next in Thread]