[Freeciv-Dev] Re: Split patch (was Re: [RFC PATCH] init_techs)

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 06:52 PM 01/09/30 +0200, Raimar Falke wrote:
>On Fri, Sep 28, 2001 at 07:42:07PM -0400, Ross W. Wetmore wrote:
>> At 09:52 AM 01/09/28 +0200, Raimar Falke wrote:
>> A better way is to just implement split to take a buffer and do its
>> splitting thing in a reasonable and efficient manner.
>
>There should be a big fat comment about the lifetime of the result and
>memory issues if split() is be done this way.

There are no lifetime issues if split doesn't do internal mallocs but
just updates the memory it was given.

The only time you need such warnings is when you use VERY bad programming
practices, and the problem is that most of the time no one is looking at
the spots where the warnings are posted.

>> your VERY bad programming practices
>
>Ross: this is a bit insulting. Please stop it.

If you find it insulting, then don't keep proposing bad solutions after 
you have been told they are bad. No one will have to keep reminding you 
then.

>       Raimar
>
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
> "Many of my assistants were fans of Tolkien, who wrote 'Lord of the Rings'
>  and a number of other children's stories for adults.  The first character
>  alphabet that was programmed for my plotter was Elvish rather than Latin."
>    -- from SAIs "life as a computer for a quarter of a century"
>
>