[Freeciv-Dev] Re: [PATCH] is_real_tile().

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 10:10 AM 01/09/28 +0200, Raimar Falke wrote:
>On Fri, Sep 28, 2001 at 03:14:40AM +0200, Gaute B Strokkenes wrote:
>> On Fri, 28 Sep 2001, gs234@xxxxxxxxx wrote:
>> > 
>> > This patch contains a macroised version of is_real_tile(), as
>> > discussed previously.  I do not have the means to profile this
>> > extensively ATM, but recent findings show that the run-time impact
>> > of the function call overhead is significant here.
>
>I think it is unnecessary. 

Mark this on your calendar. We agree 100% on this.

Besides, the mailing list soundly rejected these ideas of Gaute's when
he first argued them, and they have been rejected everytime he keeps
putting them out.

His is_real_tile() concept is badly flawed, his normalize_map_pos()
does all its work before deciding that it really shouldn't have, 
and all the IS_SANE or whatever interesting cosmetic renames don't
change the fundamentals one bit ...

[...]
>       Raimar
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
> "When C++ is your hammer, everything looks like a thumb."
>    -- Steven M. Haflich

Cheers,
RossW