[Freeciv-Dev] Re: [RFC PATCH] init_techs

[Justin Moore <justin@xxxxxxxxxxx>]

> >    We have standardized error handling through the cmd_reply function.
>
> It's better to standardize more.  The quality of error messages is
> poor (you want "argument %d of the %s command must be a %s") and
> consistent wording and formatting has to be maintained by hand.

   I'm very open to suggestions.  As it stands now I was thinking of
making separate stdinio.[ch] files to contain various comment-parsing and
error formatting messages.

> > And what if I want to parse a float?  Or a float*?  Or a long, long*,
> > void*, or something else we haven't even thought of yet?  We leave them
> > trying to smash a square peg into a round hole.
>
> Most arguments are of a standard type: a number, a valid player name,
> a valid directory, an arbitrary alphanumeric identifier, a number.

   Yes.  At the moment.  I'm trying to look down the road a long, long
ways here, though.  Or at least allow for other roads to be built.  Once I
get my framework set up (if my advisor ever allows me free time :)) feel
free to argue about it and/or suggest changes.  I think my code will make
a good case, though.

> >    And I maintain that your way lies scores of programmers that want to
> > strangle someone because there is only The One (or Four) True Way(s) to
> > handle this stuff.  IMHO, Perl is the best way to parse strings; I'm just
> > trying to give programmers a content-oblivious, Perl-like way to parse
> > incoming data.
>
> Your plans are clearly a big improvement.

   Yes, most plans are improvements.  But the question remains, "Will my
code be a big improvement"? :)

-jdm

"You don't give blood then take it back again
 We're all deserving of something more"
 - "Grievance"

Department of Computer Science, Duke University, Durham, NC 27708-0129
Email:  justin@xxxxxxxxxxx