[Freeciv-Dev] Re: common/city.h

[Dirk Stoecker <stoecker@xxxxxxxx>]

On Mon, 24 Sep 2001, Raimar Falke wrote:

> > > You won't catch the wrong tests in the ai code. Either you audit the
> > > code or add checks to ensure that there are no uninitialsed type
> > > fields or other nasty things.
> > 
> > If I understand it correctly, this was left in for security reasons, when
> > these enums where introduced. So "theoretically" there should be no
> > problems. Practically there maybe some, but we never find them without
> > removing the =0. At least there should be none, which can be found by easy
> > code reviews.
> 
> This at ./ai/aicity.c:416: "else if (!bestchoice.type &&

Line 411 according to web interface.

> is_wonder(bestchoice.choice)" is one of the problems which is exists
> in the code. At least I can't tell if "!bestchoice.type" should be
> "bestchoice.type==CT_NONE" or "bestchoice.type==CT_BUILDING". So it is
> not as easy as removing the "=0".

Compared to line 255 I would say CT_BUILDING.

But I see, that there are far too much positions like this left. I thought
the progress was gone farther.

Ciao
__ 
 ____  _ _  ____  _ _    _ _  ____
|    |  |  |    |  | \  / |  |    | the cool Gremlin from Bischofswerda
|  __   |   ____|  |  \/  |  |    | WWW: http://www.dstoecker.de/
|    |  |  |       |      |  |    | PGP key available on www page.
|____| _|_ |____| _|_    _|_ |____| I hope AMIGA never stops making fun!