Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: Split patch (was Re: [RFC PATCH] init_techs)
Home

[Freeciv-Dev] Re: Split patch (was Re: [RFC PATCH] init_techs)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Freeciv Developers <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Split patch (was Re: [RFC PATCH] init_techs)
From: Justin Moore <justin@xxxxxxxxxxx>
Date: Sat, 22 Sep 2001 17:26:05 -0400 (EDT)

> > set scorelog 1
> > /set scorelog 1
> >       /set scorelog 1
> > !@#$%^&*()/set scorelog 1
> > /!@#$%^&*()set scorelog 1
> >
> >    I can see 1, 2, and maybe 3 as being valid.  But is there really any
> > reason to make the code as complex as it is just so it can handle cases 4
> > and 5?  Yes, I know, be conservative in what you send and liberal in what
> > you accept, but I think this may be a bit overboard.
>
> Ack. The parsing could be more strict.

   Will do.  I'll start on this.  I've also attached the split patch.  I
put it in common/shared.* with the other string parsing stuff.

-jdm

"You don't give blood then take it back again
 We're all deserving of something more"
 - "Grievance"

Department of Computer Science, Duke University, Durham, NC 27708-0129
Email:  justin@xxxxxxxxxxx

Attachment: split-Sep-22.patch
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]