[Freeciv-Dev] Re: [Patch] CMA 1.0 (Update)

[Andreas Kemnade <akemnade@xxxxxxxxxxx>]

Raimar Falke writes:
 > On Fri, Sep 21, 2001 at 01:41:21PM +0200, Andreas Kemnade wrote:
 > Content-Description: message body text
 > > I have cleaned up the patch a bit:
 > > - Insert $(srcdir) in include path
 > > - #include "client/attributes.h" -> #include "attributes.h"
 > >   Then you don't need to build the client in the source dir.
 > > - remove assumption about directory for glib includes
 > 
 > Thanks.
 > 
 > > Todo: Make the other clients compile
 > > 
 > > either
 > >   move gtk code from gtk to gui-gtk
 > 
 > This would leave us with a client/gui-gtk/agents directory.
To make this a bit clearer:
Move  citizen_management_frontend_gtk.* into client/gui-gtk
I don't know whether we should have agents subdirs in client/gui-*/
This would be easier to implement. 

 > 
 > > or
 > >   add some automake/autoconf magic to disable compiling of
 > >   agents/*_gtk.c when another client is compiled (and switch to the
 > >   correct file)
 > 
 > I would favor this one.
I don't know how to do this without automake warnings. I think this
will be more difficult to maintain. But if you find a solution which
looks nice I might change my opinion.

Greetings
Andreas Kemnade

PS: gettimeofday is not portable enough. (in agents.c)