[Freeciv-Dev] Re: Unused field in move_cost_map removed. (PR#964)

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

Gregory Berkolaiko wrote:
> 
> I did some experimenting with the returned field of move_cost_map (aka
> warmap),
> http://www.freeciv.org/lxr/source/server/gotohand.h?v=cvs#L38
> 
> It's intended use was to indicate to the warmap generator that a location
> has already been processed.  However, by virtue of Dijkstra's algorithm,
> such an occurence is quite rare.  This is probably the reason why it is
> not quite used (although initialised) in the currecnt code.

> If I interpret the results correctly (looking at u time), enabling the
> check sometimes gives an improvement;
> removal of the field gives stable although little improvement, it also
> reduces volume of the code and memory used, so I suggest that it should
> be applied to CVS asap.

I fully agree that this should be removed.  It is totally unnecessary to
the algorithm.

Your patch looks correct to me.

jason