[Freeciv-Dev] Re: directional system: more magic code cleanups

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Sep 17, 2001 at 03:00:43AM -0400, Jason Dorje Short wrote:
> Just to let you know where we stand, the attached patch fixes all
> remaining known magic code (unless Ross knows of more).
> 
> It does *not* fully fix dir_ok and straightest_direction as it should; I
> think Ross should provide a patch that fixes these guys properly. 
> However it is good as far as it goes.
> 
> -    best_dir = (go_y > 0) ? 7 : 2;
> +    best_dir = (go_y > 0) ? DIR8_SOUTHWEST : DIR8_NORTHEAST;
> -    best_dir = (go_y > 0) ? 5 : 0;
> +    best_dir = (go_y > 0) ? DIR8_SOUTHWEST : DIR8_NORTHWEST;

One of the DIR8_SOUTHWESTs is wrong.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "We just typed make..."
    -- Stephen Lambrigh, Director of Server Product Marketing at Informix,
                         about porting their Database to Linux