Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: [PATCH] Cleaned up more magic code in the client (PR#9
Home

[Freeciv-Dev] Re: [PATCH] Cleaned up more magic code in the client (PR#9

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] Cleaned up more magic code in the client (PR#945)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 9 Sep 2001 10:12:08 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sun, Sep 09, 2001 at 03:45:40AM -0400, Jason Dorje Short wrote:
> Raimar Falke wrote:
> 
> > Exactly what I was hoping for. This should be applied. Ross?
> 
> You should know that by committing this you are essentially agreeing to
> my plan of conversion.  Not that I think this is a bad thing, of course,
> but you should know what you are doing.

I don't see much conversion. This patch gets rid of DIR_DX2 and
eliminates magic number: very good. You two still have to convince me
that DIR_DX should take the values of (no longer existing) DIR_DX2.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Windows: From the people who brought you edlin...


[Prev in Thread] Current Thread [Next in Thread]