[Freeciv-Dev] Re: [PATCH] message window

[Francois Taiani <francois.taiani@xxxxxxxx>]

Hi Christian, Hi Karl-Ingo,

I'm very pleased that my patch arouses so much enthousiam. I am all the
more motivated to make it better. Here are some comments on the bugs
Christian reported:

Christian Knoke wrote:
> 
> 2 small bugs:
> 
> When I rejoin a game, enter "start", there are new messages,
> but the button doesn't blink.
> 

I could observe that bug too. I think it should be solved now. I've just
coded a new version of the patch that should be easier to include into
the current CVS because it only change the GTK client, leaving the rest
of the client intact. I'll try to post it tomorrow along with the few
changes you've proposed.

> The message button blinks, even when there are no messages.

I could reproduce it as well, but I'm unsure if it was introduced by the
patch. Weren't there times at which the message window would pop up even
with no messages in it ? I think it can be solved anyway. I'll work on
it.

> 
> Does anybody feel - like I do - the right place for the buttons
> would be below the turn done button?

That's a good idea. I'll make the change.

I'm working on the treaty dialog right now, but it seems a little more
difficult to solve "elegantly". Being able to cancel a treaty without
even looking at the window would be really interesting in my opinion.
But it would require that the offering nation be displayed near the
blinking button in order to make your decision.

Gruss

Francois