[Freeciv-Dev] Re: [PATCH] showing "worked"-tiles on map

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2001/08/28 13:18 , Markus Schmaus wrote:
>This is my first contribution for freeciv, so there might not all be the
>way as it should. But I would be glad for any comments, what to make
>better.

Thanks.  The patch was submitted correctly, and it applied cleanly.

>Recently I suggested to show a small village on tiles being in use of a
>city. This patch is my realisation of this (for the gtk-gui).

I have a number of issues:

- The main map is already badly cluttered.  This adds so much extra clutter
that the main map becomes indecipherable.  If this is to be included at
all, I believe it must be made a view option (and should default to off).

- You define working_sea, but never use it.  (I think having a different
graphic for sea -vs- land is a good idea.)

- Need to update the other tile sets.

- I, personally, don't like the changes to terrain1.xpm -- you've almost
doubled the number of palette entries, and actually changed two of them
(which is very disturbing).  This intrusive of a change seems quite
unnecessary.

Other than these, a good start.  Thanks, again.

jjm