[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part2 has been put in incoming

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

Raimar Falke wrote:
>On Tue, Aug 28, 2001 at 02:57:03PM -0400, Jason Dorje Short wrote:

> > Ross's patch has a greater scope than what you and I are considering;
>
>It may be possible that Ross has a greater scope but I consider the
>steps mentioned above the first ones.

I'd agree with that...but I don't think Ross will.

> > however it handles things differently than I would.
> >
> > As to the general issues:
> >
> > DIR_REVERSE has been replaced by 7-dir because Ross plans to change all
> > of the server code to use the rotational directional system, while
> > temporarily leaving the GUI using the vertical system (with magic
> > numbers).  I believe the better solution is to have all code continue to
> > use the vertical system (with no magic numbers) until all dependency
> > issues are resolved; however, I believe some of his applied patches have
> > already changed some DIR_REVERSE usages back to be 7-dir (for instance
> > in client/gui-*/mapview.c).  I feel strongly that this is not the
> > correct way to handle the problem; it makes fixing the GUI later even
> > harder.
>
>These changes weren't applied.

My mistake.  They were included in one of Ross's earlier patches, and a
search through the code did turn up 7-dir in those files.  I guess I had
patched my code at the time.

> > I will state again that non-real map positions should not be wrapped.
>
>I have nothing like this in mind.

No, but I believe others do.

> > Note that some of the patches you've applied have taken an opposite
> > approach to this plan.
>
>Please explain.

I'm specifically referring to the DIR_REVERSE(dir) => 7-dir changes
mentioned above, so never mind.

jason