[Freeciv-Dev] Re: [PATCH] a different GUI wrapping bug

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Aug 26, 2001 at 04:24:10PM -0400, Jason Dorje Short wrote:
> I'll restate that the current method of ensuring that no tile is
> displayed twice is very bad.  It doesn't limit the size of the canvas,
> instead it iterates over the whole canvas and if it wraps around then
> the normalization causes the drawing to wrap around too...so that no
> tile ever appears twice, but may get drawn many times onto the backing
> store.
> 
> Another symptom is that clicking the mouse to scroll the screen no
> longer works when the map is wrapping around.  Clicking on a tile
> usually centers that tile, but if the whole map is covered the "center"
> of the canvas is not the center of the image.  With particularly small
> maps (I tried 10x10 so that the mapview covered only a small fraction of
> the canvas) this means that clicking to center the mapview will center
> it around a seemingly arbitrary location.
> 
> For non-isometric mode, the fix for all of these is simple: limit the
> width of the canvas. 

I think this is the wrong way to do. The user should have to right to
make any size he wants. What about creating a pre-processor variable
to define if the user wants to see a tile multiple times or not. This
is just to see how much code is affected and to let people test
it. This can later be removed completely or made more available
(command line argument for example).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The BeOS takes the best features from the major operating systems. 
  It's got the power and flexibility of Unix, the interface and ease 
  of use of the MacOS, and Minesweeper from Windows."