[Freeciv-Dev] Re: review of corecleanup_06

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Aug 23, 2001 at 11:34:09PM -0400, Jason Dorje Short wrote:
> 
> I'm also not a GUI person...but I think it's obvious that this stuff
> needs fixing and adding a FIXME to the comment is more likely to get it
> done.
> 
> I now understand your separate use of DIR_DX and DIR_DX2, and I really
> hate it (I see why you did it; the whole situation is pretty
> unfortunate).  In my opinion we should do this:
> 
> - Get rid of the current DIR_DX2/DIR_DY2 arrays and usages.  Unify with
> DIR_DX/DIR_DY.  Then we will have just one directional system, even
> though it is a bad one.
> 
> - Find and fix whatever is necessary to change the directional system
> (anything dependent on the directional system).


> - Switch DIR_DX/DIR_DY to use the rotational (DIR_DX2) directional
> system.  I think we can all agree that this one is better in several
> ways.

Why is it better?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "SIGDANGER - The System is likely to crash soon"