[Freeciv-Dev] Re: [PATCH] Small improvement at genlist and maphand

[Markus Linnala <maage@xxxxxxxxx>]

Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> writes:

> find_genlist_position() does the right thing for -1. So there is only
> the overhead of one (find_genlist_position) function call.

That overhead of one function call is not negligible. More than
3%.
------------------------------------------------------------------------
  %   cumulative   self              self     total           
 time   seconds   seconds    calls  ms/call  ms/call  name    
 11.47      4.22     4.22       22   191.82   330.72  check_fow
  8.29      7.27     3.05   602241     0.01     0.01  sync_cities
  7.75     10.12     2.85 130288264     0.00     0.00  get_player
  6.74     12.60     2.48   602261     0.00     0.02  unfog_area
  5.46     14.61     2.01 33204470     0.00     0.00  map_get_tile
  5.03     16.46     1.85 24787174     0.00     0.00  map_get_player_tile
  4.73     18.20     1.74 16303894     0.00     0.00  map_get_city
  3.45     19.47     1.27       30    42.33    63.06  player_save
  3.10     20.61     1.14 26072111     0.00     0.00  find_genlist_position
  3.10     21.75     1.14 25908574     0.00     0.00  tech_exists
  2.88     22.81     1.06   604407     0.00     0.02  really_unfog_area
  2.36     23.68     0.87 26071513     0.00     0.00  genlist_iterator_init
------------------------------------------------------------------------

-- 
//Markus