Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [patch] const-int-ize SETTINGS_NUM 		Home

[Freeciv-Dev] Re: [patch] const-int-ize SETTINGS_NUM

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Justin Moore <justin@xxxxxxxxxxx>
Cc: <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [patch] const-int-ize SETTINGS_NUM
From: Gaute B Strokkenes <gs234@xxxxxxxxx>
Date: Thu, 16 Aug 2001 01:35:03 +0200 
On Wed, 15 Aug 2001, justin@xxxxxxxxxxx wrote:
> 
> Just a minor nitpicky patch ...
> 
> Rather than macro-ize SETTINGS_NUM in stdinhand.c and have it
> recalculate the size every time you reference it, why not make it an
> int or const int and save yourself some work?  Patch against 1.12.0
> attached (altho it's probably just as easy to fix it by hand :)).

There's nothing to calculate; everything in the expression is a
constant.  Also you should have made the variable static.  I see no
point in doing this, though.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
FUN is never having to say you're SUSHI!!
[Prev in Thread] Current Thread [Next in Thread]