[Freeciv-Dev] Re: [patch] const-int-ize SETTINGS_NUM

[Falk Hueffner <falk.hueffner@xxxxxxxxxxxxxxxxxxxxxxxx>]

Justin Moore <justin@xxxxxxxxxxx> writes:

> Just a minor nitpicky patch ...
> 
> Rather than macro-ize SETTINGS_NUM in stdinhand.c and have it
> recalculate the size every time you reference it, why not make it an
> int or const int and save yourself some work?  Patch against 1.12.0
> attached (altho it's probably just as easy to fix it by hand :)).

There's no point in doing so since the compiler will generate
identical code, and you can't use const ints as array size and at some
other places.

        Falk