Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2001:
[Freeciv-Dev] Duplicated code
Home

[Freeciv-Dev] Duplicated code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Duplicated code
From: Jason Dorje Short <jshort@xxxxxxxxxxxxx>
Date: Sat, 28 Jul 2001 13:24:10 -0400

The function init_warmap is called at the beginning of
really_generate_warmap:

http://www.freeciv.org/lxr/source/server/gotohand.c?v=cvs#L293

However, generate_warmap calls this function right before calling
really_generate_warmap in several instances:

http://www.freeciv.org/lxr/source/server/gotohand.c?v=cvs#L400

What gives?  Aside from being wasteful, this seems rather bug-prone.

jason


[Prev in Thread] Current Thread [Next in Thread]