Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2001:
[Freeciv-Dev] Re: Unsafe assertions. (PR#864)
Home

[Freeciv-Dev] Re: Unsafe assertions. (PR#864)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Freeciv-dev mailing list <freeciv-dev@xxxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Unsafe assertions. (PR#864)
From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
Date: Fri, 27 Jul 2001 11:24:58 -0700 (PDT)

On Fri, 27 Jul 2001, Thue Janus Kristensen wrote:
> Here is a patch:

I think Jason's way was a lot better.  You have weakened all the assertions by
only checking is_real instead of checking for is_normal.  You also normalize
every time, when the author might very well have intended to assert that
normalization was NOT necessary.



[Prev in Thread] Current Thread [Next in Thread]