Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2001:
[Freeciv-Dev] Re: Unsafe assertions. (PR#864)
Home

[Freeciv-Dev] Re: Unsafe assertions. (PR#864)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jason Dorje Short <jshort@xxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Unsafe assertions. (PR#864)
From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
Date: Thu, 26 Jul 2001 17:38:29 -0700 (PDT)

On Thu, 26 Jul 2001, Jason Dorje Short wrote:
> 
> I do believe is_normal_map_pos() is a good check that should be used.
> 

That's what I would do.  is_normal is a stronger assertion than is_real, so
it makes sense to keep using that one.  If it fails somewhere, figure out if
it should have been a check for is_real, or if the author intended to
normalize the coordinate inside the assert (bad coder!).



[Prev in Thread] Current Thread [Next in Thread]