[Freeciv-Dev] Re: server/diplhand.c patch - fixes a city trading glitch + shared vision messages (fwd) (PR#808)

[Thue <thue@xxxxxxx>]

On Thursday 21 June 2001 17:56, Michael Zinn wrote:
> And further to this... here's the actual patch (attached) (ahem, sorry)
>
> ----- Forwarded message from michaelz -----
>
> Date: Fri, 22 Jun 2001 01:45:03 +1000
> To: bugs@xxxxxxxxxxxxxxxxxxx
> Subject: server/diplhand.c patch - fixes a city trading glitch + shared
> vision messages
>
> Part 1: (inserted line 245)
>   - missing break causes city trades to fail if:
>      * the person giving the city away accepted first
>  AND * the pesron giving the city away has less gold than the city's ID
>
> Part 2: (modified lines 382-383 or 383-384 depending on part 1 :P)
>   - `Game: pgiver->name gives you shared vision' is now sent to the pdest,
>        whereas previously:
>     `Game: pdest->name gives you shared vision' was sent to pgiver
>
>  This was probably never noticed because giving shared vision is almost
> always a reciprocal thing, I guess, and it looks just fine in that
> scenario...

Arrrg - evil bugs. Applied.
I think the "break" should be another place than where you put it, so I moved 
it.

-Thue