[Freeciv-Dev] server/diplhand.c patch - fixes a city trading glitch + shared vision messages (fwd) (PR#808)

[michaelz@xxxxxxxxxxxxxxx (Michael Zinn)]

And further to this... here's the actual patch (attached) (ahem, sorry)

----- Forwarded message from michaelz -----

Date: Fri, 22 Jun 2001 01:45:03 +1000
To: bugs@xxxxxxxxxxxxxxxxxxx
Subject: server/diplhand.c patch - fixes a city trading glitch + shared vision 
messages

Part 1: (inserted line 245)
  - missing break causes city trades to fail if:
     * the person giving the city away accepted first
 AND * the pesron giving the city away has less gold than the city's ID

Part 2: (modified lines 382-383 or 383-384 depending on part 1 :P)
  - `Game: pgiver->name gives you shared vision' is now sent to the pdest,
       whereas previously:
    `Game: pdest->name gives you shared vision' was sent to pgiver

 This was probably never noticed because giving shared vision is almost always
  a reciprocal thing, I guess, and it looks just fine in that scenario...


If you *really* want me to submit these as separate patches, let me know and
I can...


System details, although the patches are fairly obvious oversights if you
look at the code, so hopefully not necessary:

  Linux (Debian 2.2r3 with nothing relevant in /usr/local)
  Bugs tested and verified with freeciv-1.11.5-devel 2001-06-22 
                  (or -21 depending on which part of the world you're in ;-p)
  GTK client
  
  My details - see .sig :-) yes, its all true (well, except for the `Wumpus' 
bit :P)
-- 
Michael `Wumpus' Zinn | "The Universe speaks in many languages, but only one
  michael.z@xxxxxxx   |  voice ... it speaks in the language of hope... trust
         <*>          |  ... and compassion; it is the language of the Heart"
                      |    -- G'Kar's Declaration of Principles (Babylon 5)

diplhand.diff
Description: Text document