[Freeciv-Dev] Re: [PATCH] _final_ *snprintf cleanup. (PR#774)
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Friday 18 May 2001 13:59, Gaute B Strokkenes wrote:
>The attached patch supercedes all of my previous patches, and does the
>following:
>
> * Use an autoconf test rather than a runtime test to check if a
> given vsnprintf() is suitable.
>
> * Change vsnprintf() test to accept C89 as well C99 return value
> semantics.
>
> * Changed vsnprintf wrapper to have C89 return value semantics, even
> if the underlying implementation is C99.
>
> * Changed all uses of my_vsnprintf() and friends to expect C89
> rather than C99 return values.
>
>The only drawback is that this makes it slighly harder to
>cross-compile Freeciv, though in practise I doubt that this is
>possible anyway.
You define a function AC_FUNC_VSNPRINTF. That should probably be
FC_FUNC_VSNPRINTF like the other native freeciv functions.
Just curious, why not conform to the newer C99 standard?
(I only looked shortly at the patch)
-Thue
|
|