[Freeciv-Dev] Re: population cost patch

[Arien Malec <arien_malec@xxxxxxxxx>]

--- Arien Malec <arien_malec@xxxxxxxxx> wrote:
> See my previous e-mail: the problem is in request_unit_build_city

Oops, I misread the code: it only does the PACKET_CITY_NAME_SUGGEST_REQ
thing on the basis of can_unit_build_city...

But I think the problem is here:

http://www.freeciv.org/lxr/source/server/unithand.c?v=cvs#L381

if (!unit_flag(punit->type, F_CITIES)) {
  char *us = get_units_with_flag_string(F_CITIES);
  notify_player_ex(pplayer, punit->x, punit->y, E_NOEVENT,
                   _("Game: Only %s can build or add to a city."), us);
  free(us);
  return;
}

Should be tests on F_CITIES && F_ADD_TO_CITY

IMHO, the functions for building a city and adding to a city should be
separated....

Arien  


__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail. 
http://personal.mail.yahoo.com/