[Freeciv-Dev] Re: (NEW PATCH) settler_worker_cost patch

[Arien Malec <arien_malec@xxxxxxxxx>]

--- Michael Kiermaier <michael.kiermaier@xxxxxxx> wrote:
> please notice that i will rename all the worker-stuff into pop,
> because in
> fact the population number (which consists of workers and
> specialists) is
> reduced and not necessarily the worker number.
> if you do not agree, we can discuss it and eventually change it to
> something
> different.

Sounds fine to me. In fact, there is currently a comment in cityturn.c
mentioning that the current test for an F_SETTLERS type worker should
be changed into a test for "pop" so we would then be consistent with
the current code's suggested plan....
> 
> > > at the moment i have a problem:
> > > i changed the can_unit_add_to_city function according to my new
> > > F_ADD_TO_CITY flag. when i click on the menu item "add to city"
> or
> > > "build
> > > city" everything works fine.
> > > but pressing the "b" key only adds F_CITIES (or F_SETTLERS?)
> units to
> > > a city
> > > and not all units with the F_ADD_TO_CITY flag.
> > >
> > > can anyone imagine a reason for this behavior? where can i find
> the
> > > code
> > > that handles keyboard inputs?
> >
> > You want to change can_unit_add_to_city in unit.c
> 
> i did change this function, and adding to a city basically works. but
> not
> for F_ADD_TO_CITY-only units together with pressing the keyboard-"b".

Strange. "b" should trigger the MENU_ORDER_BUILD_CITY callback action,
which should trigger:

http://www.freeciv.org/lxr/source/client/gui-gtk/menu.c?v=cvs#L305

That code does a test on can_unit_add_to_city....

The chain of calls leads to:

http://www.freeciv.org/lxr/source/client/control.c?v=cvs#L557

Which then does a test on can_unit_build_city, and here we have the
problem....

Arien

__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail. 
http://personal.mail.yahoo.com/