[Freeciv-Dev] Re: strange results (PR#691)

[David Pfitzner <dwpfitzner@xxxxxxxxx>]

Reinier Post <rp@xxxxxxxxxx> wrote: 

> On Thu, Feb 08, 2001 at 11:37:57AM -0800, di00grbj@xxxxxxxxx wrote:

> > Got literacy up to 113%
> > It was in the end of a really long game, with lot of knowledge and
> universities
> > in most towns.
> 
> I don't think this is a bug.  I don't know what the percentage
> means, either; looking at the way it's computed,
> 
>   http://www.freeciv.org/lxr/source/common/game.c#L536
> 
> it isn't a percentage at all.  It is a useless statistic anyway.

Its simply the percentage of your population which has a University
in their city, where a Library counts as half a University.

I'm guessing the problem is that in report.c:rank_count_literacy(),
it calculates the precentage using the "literate population"
which was calculated whenever civ_score() was last run (previous 
end of turn?), but it uses the _current_ total population.

So rank_count_literacy should use pplayer->score.population
(as, eg, rank_population() does) instead of calculating via
civ_population().  Ditto rank_calc_mil_service().  And possibly 
also report_demographics() should re-run civ_score() so the data 
is current.

-- David

__________________________________________________
Do You Yahoo!?
Get personalized email addresses from Yahoo! Mail - only $35 
a year!  http://personal.mail.yahoo.com/