Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2001:
[Freeciv-Dev] Re: [PATCH] Worklist performance fix 		Home

[Freeciv-Dev] Re: [PATCH] Worklist performance fix

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Cc: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [PATCH] Worklist performance fix
From: Thue <thue@xxxxxxx>
Date: Tue, 6 Feb 2001 17:05:58 +0100 
On Tuesday 06 February 2001 17:00, Raimar Falke wrote:
> On Tue, Feb 06, 2001 at 04:27:08PM +0100, Thue wrote:
> > On Tuesday 06 February 2001 00:23, Raimar Falke wrote:
> > > Hi,
> > >
> > > I profiled the client and found that has_capability() isn't cheap. The
> > > profile showed put_worklist() and iget_worklist() at top
> > > positions. The patch fixed this and also formats the methods properly.
> > >
> > > If the problem resurfaces it may also be possible to tackle it in a
> > > general way.
> >
> > The capability checking will be removed with the next release,
>
> And be replaced with?
>
> > so no need to try to optimize it...
>
> argl
>
>       Raimar

I meant that specific capability check will go away as we add a mandatory 
+1.12 cap string; the capability functionality will remain.

-Thue
[Prev in Thread] Current Thread [Next in Thread]