[Freeciv-Dev] Re: Compiler-warnings

[Gerhard Killesreiter <killesreiter@xxxxxxxxxxxxxxxxxxxxxx>]

Dirk Stoecker <stoecker@xxxxxxxxxxxxxx> writes:

> A function maybe called with argument of type char (8 bit). But the
> compiler does not do that, but internally uses int (usally 32 bit)
> normally. Thus there maybe portability problems.
> This can be the problem of signed/unsigned mode Falk talks about or
> others.

I see. Thank you.

> Nobody will fix them I think, but please be so kind and send me the list.

I append is (sorry, my MIME-setup is broken). It's not as much as I thought.

> Maybe I'm so dumb and will fix them any day (like I will fix all my SAS-C
> warnings also).

> > _Iff_ somebody would explain to me what to change in the source, I
> > _might_ try my hands on a patch. To silence the warnings, or do
> > whatever to them.
> 
> Change every function prototype, where char is used to int and check all
> the function calls for side-effects.
> 


It's the last part, that worries me.


Cheers,
        Gerhard

make[2]: Entering directory `/home/killes/ftp/freeciv/intl'
localealias.c: In function `read_alias_file':
localealias.c:291: warning: subscript has type `char'
localealias.c:298: warning: subscript has type `char'
localealias.c:305: warning: subscript has type `char'
localealias.c:314: warning: subscript has type `char'
l10nflist.c: In function `_nl_normalize_codeset':
l10nflist.c:365: warning: subscript has type `char'
l10nflist.c:369: warning: subscript has type `char'
l10nflist.c:383: warning: subscript has type `char'
l10nflist.c:385: warning: subscript has type `char'
rm -f libintl.a
: libintl.a
make[2]: Leaving directory `/home/killes/ftp/freeciv/intl'
Making all in common
make[2]: Entering directory `/home/killes/ftp/freeciv/common'
capability.c: In function `has_capability':
capability.c:36: warning: subscript has type `char'
capability.c:41: warning: subscript has type `char'
inputfile.c: In function `check_include':
inputfile.c:337: warning: subscript has type `char'
inputfile.c:354: warning: subscript has type `char'
inputfile.c: In function `get_token_entry_name':
inputfile.c:642: warning: subscript has type `char'
inputfile.c:648: warning: subscript has type `char'
inputfile.c:651: warning: subscript has type `char'
inputfile.c: In function `get_token_eol':
inputfile.c:678: warning: subscript has type `char'
inputfile.c: In function `get_token_white_char':
inputfile.c:705: warning: subscript has type `char'
inputfile.c: In function `get_token_value':
inputfile.c:752: warning: subscript has type `char'
inputfile.c:758: warning: subscript has type `char'
inputfile.c:761: warning: subscript has type `char'
inputfile.c:765: warning: subscript has type `char'
inputfile.c:785: warning: subscript has type `char'
registry.c: In function `section_file_save':
registry.c:604: warning: subscript has type `char'
registry.c:605: warning: subscript has type `char'
registry.c:608: warning: subscript has type `char'
shared.c: In function `skip_leading_spaces':
shared.c:312: warning: subscript has type `char'
shared.c: In function `remove_trailing_spaces':
shared.c:349: warning: subscript has type `char'
shared.c: In function `wordwrap_string':
shared.c:411: warning: subscript has type `char'
shared.c:420: warning: subscript has type `char'
rm -f libcivcommon.a
: libcivcommon.a
make[2]: Leaving directory `/home/killes/ftp/freeciv/common'
Making all in ai
make[2]: Entering directory `/home/killes/ftp/freeciv/ai'
rm -f libcivai.a
: libcivai.a
make[2]: Leaving directory `/home/killes/ftp/freeciv/ai'
Making all in server
make[2]: Entering directory `/home/killes/ftp/freeciv/server'
savegame.c: In function `map_rivers_overlay_load':
savegame.c:149: warning: subscript has type `char'
savegame.c:151: warning: subscript has type `char'
savegame.c: In function `map_load':
savegame.c:212: warning: subscript has type `char'
savegame.c:213: warning: subscript has type `char'
savegame.c:231: warning: subscript has type `char'
savegame.c:232: warning: subscript has type `char'
savegame.c:249: warning: subscript has type `char'
savegame.c:250: warning: subscript has type `char'
savegame.c:268: warning: subscript has type `char'
savegame.c:269: warning: subscript has type `char'
savegame.c:287: warning: subscript has type `char'
savegame.c:288: warning: subscript has type `char'
savegame.c:304: warning: subscript has type `char'
savegame.c:305: warning: subscript has type `char'
savegame.c:319: warning: subscript has type `char'
savegame.c:320: warning: subscript has type `char'
savegame.c:335: warning: subscript has type `char'
savegame.c:336: warning: subscript has type `char'
savegame.c: In function `player_map_load':
savegame.c:1034: warning: subscript has type `char'
savegame.c:1035: warning: subscript has type `char'
savegame.c:1053: warning: subscript has type `char'
savegame.c:1054: warning: subscript has type `char'
savegame.c:1071: warning: subscript has type `char'
savegame.c:1072: warning: subscript has type `char'
savegame.c:1089: warning: subscript has type `char'
savegame.c:1099: warning: subscript has type `char'
savegame.c:1110: warning: subscript has type `char'
savegame.c:1122: warning: subscript has type `char'
stdinhand.c: In function `rulesout_command':
stdinhand.c:1824: warning: subscript has type `char'
stdinhand.c: In function `cmdlevel_command':
stdinhand.c:1957: warning: subscript has type `char'
stdinhand.c:1960: warning: subscript has type `char'
stdinhand.c:2000: warning: subscript has type `char'
stdinhand.c:2004: warning: subscript has type `char'
stdinhand.c: In function `explain_option':
stdinhand.c:2224: warning: subscript has type `char'
stdinhand.c:2225: warning: subscript has type `char'
stdinhand.c: In function `show_command':
stdinhand.c:2368: warning: subscript has type `char'
stdinhand.c:2369: warning: subscript has type `char'
stdinhand.c: In function `is_ok_opt_name_char':
stdinhand.c:2451: warning: subscript has type `char'
stdinhand.c: In function `is_ok_opt_value_char':
stdinhand.c:2459: warning: subscript has type `char'
stdinhand.c: In function `handle_stdin_input':
stdinhand.c:2588: warning: subscript has type `char'
stdinhand.c:2598: warning: subscript has type `char'
stdinhand.c:2600: warning: subscript has type `char'
stdinhand.c:2624: warning: subscript has type `char'
stdinhand.c:2628: warning: subscript has type `char'
rm -f libcivserver.a
: libcivserver.a
ld32: WARNING 84: ../ai/libcivai.a is not used for resolving any symbol.
ld32: WARNING 84: ./libcivserver.a is not used for resolving any symbol.
make[2]: Leaving directory `/home/killes/ftp/freeciv/server'
Making all in client
make[2]: Entering directory `/home/killes/ftp/freeciv/client'
Making all in gui-xaw
make[3]: Entering directory `/home/killes/ftp/freeciv/client/gui-xaw'
echo '/**************************************************/' > Freeciv.h
echo '/* DO NOT EDIT THIS FILE, EDIT ../../data/Freeciv */' >> Freeciv.h
echo '/**************************************************/' >> Freeciv.h
./ad2c ../../data/Freeciv >> Freeciv.h
cd ../.. \
  && CONFIG_FILES=client/gui-xaw/Makefile CONFIG_HEADERS= /bin/sh 
./config.status
creating client/gui-xaw/Makefile
linking ./intl/libgettext.h to intl/libintl.h
make[3]: Leaving directory `/home/killes/ftp/freeciv/client/gui-xaw'
make[3]: Entering directory `/home/killes/ftp/freeciv/client/gui-xaw'
rm -f libguiclient.a
: libguiclient.a
make[3]: Leaving directory `/home/killes/ftp/freeciv/client/gui-xaw'
make[3]: Entering directory `/home/killes/ftp/freeciv/client'
clinet.c: In function `create_server_list':
clinet.c:257: warning: subscript has type `char'





-- 
Dipl.-Phys. Gerhard Killesreiter <killesreiter@xxxxxxxxxxxxxxxxxxxxxx>
Ein Bier, das nicht getrunken wird, hat seinen Beruf verfehlt.
                                        Bierzeitung des VDSt Dresden, 192x